Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previewing a Poll thread results in error message #5792

Closed
m4z opened this issue Sep 4, 2019 · 1 comment · Fixed by #6380
Closed

Previewing a Poll thread results in error message #5792

m4z opened this issue Sep 4, 2019 · 1 comment · Fixed by #6380
Labels
Polls
Milestone
RC4

Comments

@m4z
Copy link

m4z commented Sep 4, 2019

Description

Original report here

Steps to reproduce

  1. In a board, click "new poll"
  2. add some stuff to the input fields (subject, question, two or more options, message text) so you have a valid poll and don't get any other errors when previewing
  3. click "preview"
  4. Admire the error message above the input area:

The message has the following error or errors that must be corrected before continuing:
You must have at least two choices!

Environment (complete as necessary)

  • Version/Git revision: 2.1rc2
  • Database Type: postgres (but probably any)
  • Database Version: 9.4.21 (debian)
  • PHP Version: 5.6.40 (debian)
@sbulen sbulen added the Polls label Sep 5, 2019
@SychO9
Copy link
Contributor

SychO9 commented Sep 5, 2019 •
edited

Looking at the code, poll options were never handled:
https://github.com/SimpleMachines/SMF2.1/blob/f9bd04630420e687b6158cea2bfe00d6f257d479/Themes/default/scripts/script.js#L1834-L1844

@MissAllSunday MissAllSunday added this to the Final milestone Sep 9, 2019
BrickOzp pushed a commit to BrickOzp/SMF2.1 that referenced this issue Nov 27, 2020
@SGA-oscar-rydhe
Send poll options on preview
1038fba 
Send the poll options when previewing, to avoid
an error message about missing poll options.

Fixes SimpleMachines#5792

Signed-off-by: Oscar Rydhé oscar.rydhe@gmail.com
@BrickOzp BrickOzp mentioned this issue Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Polls
Projects
None yet
Milestone
RC4
Development

Successfully merging a pull request may close this issue.

Send poll options on preview BrickOzp/SMF2.1
4 participants
@m4z @MissAllSunday @SychO9 @sbulen