Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BBC nit - list & li #6023

Closed
sbulen opened this issue Feb 17, 2020 · 2 comments · Fixed by #6340
Closed

BBC nit - list & li #6023

sbulen opened this issue Feb 17, 2020 · 2 comments · Fixed by #6340
Labels
BBC
Milestone
RC4

Comments

@sbulen
Copy link
Contributor

sbulen commented Feb 17, 2020 •
edited

Description

The list & li BBC codes are enabled separately, but neither work properly unless both are enabled. Behavior is inconsistent.

Steps to reproduce

SCENARIO 1: Both enabled; both buttons visible in editor; both work:
image
image

SCENARIO 2: li enabled, list disabled; neither button visible in editor; all lists (numbered or not) appear as bullets:
image

SCENARIO 3: list enabled, li disabled; both buttons visible in editor; neither work:
image

Environment (complete as necessary)

  • Version/Git revision: Now
  • Database Type: MySQL
  • Database Version: 5.7
  • PHP Version: 7.3

Additional information/references

Issue exists for both 2.1 & 2.0. Initially reported here:
https://www.simplemachines.org/community/index.php?topic=547426.0
@sbulen
Copy link
Contributor Author

sbulen commented Feb 17, 2020

My suggestion is to keep it simple. One setting affects both buttons/features. I'm not sure it makes sense to enable/disable li separately from list...

@sbulen sbulen added the BBC label Feb 18, 2020
@Sesquipedalian
Copy link
Member

Yeah, that should be controlled with a single setting. We should probably do the same for the table-related ones, too.

@MissAllSunday MissAllSunday added this to the Final milestone Jul 20, 2020
BrickOzp pushed a commit to BrickOzp/SMF2.1 that referenced this issue Nov 13, 2020
@SGA-oscar-rydhe
Remove child bbc tags from enable settings
9af4957 
It makes no sense of handling bbc codes that requires other tags
to work. For example li that is a sub tag of list.
Remove all bbc child codes from the enable/disable settings page
and let the parent settings control also the children.

Fixes SimpleMachines#6023
@BrickOzp BrickOzp mentioned this issue Nov 13, 2020
Merged
BrickOzp pushed a commit to BrickOzp/SMF2.1 that referenced this issue Nov 13, 2020
@SGA-oscar-rydhe
Remove child bbc tags from enable settings
37dd6bc 
It makes no sense of handling bbc codes that requires other tags
to work. For example li that is a sub tag of list.
Remove all bbc child codes from the enable/disable settings page
and let the parent settings control also the children.

Fixes SimpleMachines#6023
MissAllSunday pushed a commit that referenced this issue Feb 3, 2021
@SGA-oscar-rydhe @MissAllSunday
Remove child bbc tags from enable settings
68b1f90 
It makes no sense of handling bbc codes that requires other tags
to work. For example li that is a sub tag of list.
Remove all bbc child codes from the enable/disable settings page
and let the parent settings control also the children.

Fixes #6023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BBC
Projects
None yet
Milestone
RC4
Development

Successfully merging a pull request may close this issue.

Remove child bbc tags from enable settings BrickOzp/SMF2.1
3 participants
@Sesquipedalian @MissAllSunday @sbulen