Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New replies warning can no longer be disabled #6851

Closed
sbulen opened this issue Jul 17, 2021 · 5 comments · Fixed by #6852
Closed

New replies warning can no longer be disabled #6851

sbulen opened this issue Jul 17, 2021 · 5 comments · Fixed by #6852

Comments

@sbulen
Copy link
Contributor

sbulen commented Jul 17, 2021

Description

Reported in the forum:
https://www.simplemachines.org/community/index.php?topic=578187.0
https://www.simplemachines.org/community/index.php?topic=577845.0
https://www.simplemachines.org/community/index.php?topic=537677.0

Yes, in high volume forums this would be extremely annoying.

There was a setting in 2.0 that was removed in 2.1 for some reason. (Possibly in error? The setting is still referenced in the code...)

Should be logged. I would not flag it for Final.

@sbulen
Copy link
Contributor Author

sbulen commented Jul 17, 2021

Looks like this was always controversial. There is no reason documented for the change.
#1082

@Sesquipedalian Sesquipedalian self-assigned this Jul 17, 2021
@Sesquipedalian
Copy link
Member

Yeah, I think we should probably revert #1082.

Sesquipedalian added a commit to Sesquipedalian/SMF that referenced this issue Jul 17, 2021
Fixes SimpleMachines#6851

Signed-off-by: Jon Stovell <jonstovell@gmail.com>
@Sesquipedalian Sesquipedalian added this to the Final milestone Jul 17, 2021
@Sesquipedalian
Copy link
Member

I would not flag it for Final.

I disagree. The fix is fast and easy, and the issue is very frustrating for those whom it affects. All we are doing is bringing back a user setting that existed in 2.0.

@sbulen
Copy link
Contributor Author

sbulen commented Jul 17, 2021

I sure wish the reason for the change was documented.

Chesterton's fence... (https://fs.blog/2020/03/chestertons-fence/)

One of the reasons I'm so conservative when it comes to such changes....

Sesquipedalian added a commit to Sesquipedalian/SMF that referenced this issue Jul 17, 2021
Fixes SimpleMachines#6851

Signed-off-by: Jon Stovell <jonstovell@gmail.com>
@Sesquipedalian
Copy link
Member

Sesquipedalian commented Jul 17, 2021

My guess is that it was removed in pursuit of greater simplicity in a Simple Machines Forum. I get the reasoning there, but this has turned out to be a case where "everything should made be as simple as possible, but no simpler."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants