Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Share #1588

Closed
wants to merge 4 commits into from
Closed

Social Share #1588

wants to merge 4 commits into from

Conversation

XinYenFon
Copy link
Contributor

This PR is for preview! Please do not merge this...

  • Testing the basic functions.
  • Uses $context['canonical_url']
  • Uses static share URLs
  • No JS/Ajax used (both sided no FB/Twitter/G+ JS files included too)
  • Has only enable-disable function (requested by Oldiesmann)
  • Includes: Facebook - Google+ - Twitter only.

Signed-off-by: Antes antes@simplemachines.org

@XinYenFon
social share first commit
8895b51 
Signed-off-by: Antes <antes@simplemachines.org>
@live627
Copy link
Contributor

live627 commented Apr 28, 2014

O_o

@XinYenFon
better with you... not you, i mean beer!
7b1b8ff 
Signed-off-by: Antes <antes@simplemachines.org>
@XinYenFon XinYenFon changed the title Social Share Integration Social Share May 9, 2014
@XinYenFon
Another conflict to resolve :)
ec880ce 
Signed-off-by: Antes <antes@simplemachines.org>
@XinYenFon
Change little and make it clear.
cbf21d2 
Signed-off-by: Antes <antes@simplemachines.org>
@XinYenFon
Copy link
Contributor Author

huh I didn't committed those changes :/ well screwed :P

@XinYenFon XinYenFon closed this May 15, 2014
@XinYenFon XinYenFon deleted the social branch May 15, 2014 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XinYenFon @live627