Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 Session Handling #3230

Merged
merged 2 commits into from Jan 29, 2016

Conversation

albertlast
Copy link
Collaborator

I played today with php 7 and noticed that php 7 got a stricter version of customer session handling,
see: http://stackoverflow.com/questions/34117651/php7-symfony-2-8-failed-to-write-session-data

So I modified some session function that they return true or false.
Based on the information if the db action was successful or not.

The intial error was: http://snag.gy/hDZPk.jpg

Error-msg in log:
2: Unknown: Session callback expects true/false return value

2: Unknown: Failed to write session data (user). Please verify that the current setting of session.save_path is correct (D:\Programme\xampp\tmp)

Signed-off-by: albertlast  <albertlast@hotmail.de>
Signed-off-by: albertlast  <albertlast@hotmail.de>
@Dragooon
Copy link
Contributor

Dragooon commented Jan 7, 2016

I'm guessing this is backwards compatible until 5.2.7?

@albertlast
Copy link
Collaborator Author

I'm dunno.
But the target of smf 2.1 is php 5.3+

Oldiesmann added a commit that referenced this pull request Jan 29, 2016
@Oldiesmann Oldiesmann merged commit dd4222b into SimpleMachines:release-2.1 Jan 29, 2016
@albertlast albertlast deleted the php7SessionHandling branch March 25, 2016 06:26
@asmith20002 asmith20002 mentioned this pull request Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants