Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some logic for deciding what question to print in verification #5358

Conversation

@Sesquipedalian
Copy link
Member

Sesquipedalian commented Jan 22, 2019

Before this, if reCAPTCHA was enabled, visual verification was disabled, and verification questions were required, it was possible for undefined index errors to be generated.

Signed-off-by: Jon Stovell <jonstovell@gmail.com>
@Sesquipedalian Sesquipedalian changed the title Fixes some logic for decided what question to print in verification Fixes some logic for deciding what question to print in verification Jan 22, 2019
@Sesquipedalian

This comment has been minimized.

Copy link
Member Author

Sesquipedalian commented Jan 23, 2019

Since this (1) is small, (2) is simple and obvious, (3) has been tested under all conditions that could affect it, and (4) fixes a (minor) security-related problem, I'm going to go ahead and merge it for RC1 now.

@Sesquipedalian Sesquipedalian merged commit eadb1a1 into SimpleMachines:release-2.1 Jan 23, 2019
2 checks passed
2 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Sesquipedalian Sesquipedalian deleted the Sesquipedalian:verification_question branch Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.