Alerts system #5566
Alerts system #5566
Conversation
Additionally alows mods to specify if the alert should be using multiple links instead of one unique link. through 'show_links' extra array item Signed-off-by: SychO <sychocouldy@gmail.com>
Signed-off-by: SychO <sychocouldy@gmail.com>
Signed-off-by: SychO <sychocouldy@gmail.com>
Signed-off-by: SychO <sychocouldy@gmail.com>
Signed-off-by: SychO <sychocouldy@gmail.com>
Signed-off-by: SychO <sychocouldy@gmail.com>
Signed-off-by: SychO <sychocouldy@gmail.com>
Signed-off-by: SychO <sychocouldy@gmail.com>
|
I wonder if it'd be a good idea to use the og_image for an alert that doesn't have a sender avatar |
|
This didn't really fix #5408 since that link was not modified. Problem is that the relevant alerts don't use the message id. Perhaps that could be fixed by using new: |
|
really ? did you try with the PR's changes and then recreate a "X replied to Y " alert and see ? cause I'm pretty positive it fixes it from what I've noticed, that type of alert has 2 links, one is the poster's, the other is the topic's, |
|
the popup is fine; the issue is in the "All alerts" page.
…On Tue, Apr 2, 2019 at 10:18 AM SychO ***@***.***> wrote:
really ? did you try with the PR's changes and then recreate a "X replied
to Y " alert and see ? cause I'm pretty positive it fixes it
from what I've noticed, that type of alert has 2 links, one is the
poster's, the other is the topic's,
however the alert has a *content_link* value in its extra db json array,
the value of content_link is a correct link containing .new#new at the
end, and since this PR prioritizes the value of content_link if it exists,
that means that alert takes to the newest post
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5566 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAaWtz2wR96kpgO9Bqh50KKHEI05RXKJks5vc5DXgaJpZM4cWEXt>
.
|
|
Oh this commit should fix that, it basically adds an icon with a link to the alert |
|
that link is generated in fetch_alerts() |
Signed-off-by: SychO <sychocouldy@gmail.com>
I have no opinion on this. Could @Gwenwyfar weigh in on this? |
|
One last thing, I'm seeing a 'icon' for alerts in the template file but nothing that actually creates that item on the source file, unless I'm missing something I wonder if we could ask @Arantor if he remembers anything :p |
|
I remember thinking I wanted to support icons but in practice avatars were better so this could really go. |
Signed-off-by: SychO <sychocouldy@gmail.com>
Oh I see, it can go then thank you |
This is my proposed PR that closes #4950 and closes #5408 and closes #5412