PHP 7.4 Deprecations

[jdarwood007]

This will need some testing because it changes a lot of curly braces usage.

This will fix #5888 when merged

[jdarwood007]

SMF 2.0 has a lot of these as well.
Also I used this to locate and replace the curly braces:
Search: $([A-Za-z0-9_]+){$([A-Za-z0-9]+)}
Replace: $\1[$\2]

Also searched for and found a few more: $([A-Za-z0-9_]+){

[ghost]

Another thing :

Trying to access array offset on value of type bool

/Sources/Subs-Attachments.php (Line 516)

[ghost]

if (isset($context['valid_image_types'][$size[2]]))

No idea how to re-rewrite it in a PHP 7.4 compatible way.

Also I'm running this PR on my forum.

[jdarwood007]

I won't have time till the weekend to look at that but where is that? Thats valid code and not deprecated.

[ghost]

I won't have time till the weekend to look at that but where is that? Thats valid code and not deprecated.

/Sources/Subs-Attachments.php (Line 516)

With the following PHP error generated :

Trying to access array offset on value of type bool

[ghost]

One more :

/Sources/ManageErrors.php (Line 168)
Trying to access array offset on value of type null

[jdarwood007]

This was already fixed in another PR. Update your stuff.

As well merge this PR into your code if your testing PHP 7.4. It should be compatible.

[ghost]

main branch + this, is that what was required ?

Done anyway, only seeing approve_query message now. (php error)

[Sesquipedalian]

Is this ready to merge, @jdarwood007?

[albertlast]

For porpuse of testing would be this pr very important,
got many depraction "notice".

[albertlast]

Run this command

forfiles /s /p F:\github\SMF2.1\ /m *.php /c "cmd /c D:\Programme\wamp64\bin\php\php7.4.1\php.exe -l @file" > 7.4.check.txt

result is that no syntax error was found.

When i do vs the main i found many depracted notice

[jdarwood007]

@Sesquipedalian It is other than the possible issue reported by the deleted account. I haven't verified it. But this could merge knowing that and give us time to test it more.

[mobasuite]

Type of error: Undefined
8: Undefined variable: approve_query https://mobasuite.com/forum/index.php?action=search2
/home/lolupdat/public_html/forum/Sources/Search.php (Line 1715)

[albertlast]

this was not touched by this pr

[mobasuite]

@albertlast

True, just notifying.

[MissAllSunday]

Will go ahead and merge, we still have time to do more testing