Avoid multiple quotes for every selection #7009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you do multiple text selections in the same message, and then click the "Quote selected text" button, you would get multiple quotes with every text you selected. Remove the old click listener before adding a new on. This will only quote the latest selected text. Fixes SimpleMachines#6960 Signed-off-by: Oscar Rydhé <oscar.rydhe@gmail.com>
Sesquipedalian
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
This will only quote the latest selected text.
In my tests, it quoted whichever chunk of text was closest to the beginning of the post, rather than anything to do with the chronological order in which the chunks of text were selected.
Be that as it may, this does seem to solve the issue quite nicely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you do multiple text selections in the same message,
and then click the "Quote selected text" button, you
would get multiple quotes with every text you selected.
Remove the old click listener before adding a new on.
This will only quote the latest selected text.
Fixes #6960
Signed-off-by: Oscar Rydhé oscar.rydhe@gmail.com