Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly define a default value for credits column in log_packages #7346

Merged
merged 1 commit into from Feb 23, 2022

Conversation

albertlast
Copy link
Collaborator

Mysql got an implicit default value on credits col,
to make this point clear for both databases i convert this implicit definition to an explicit defintion.

Test case:
https://dbfiddle.uk/?rdbms=postgres_14&fiddle=664b05272751062e3981ddb055ea7744

fixes: #7345

Signed-off-by: albertlast albertlast@hotmail.de
@jdarwood007
Copy link
Member

Before this merges, we have to ensure we provide this in the upgrade logic for the patch from 2.1.1 to 2.1.2.

@Sesquipedalian Sesquipedalian merged commit d676092 into SimpleMachines:release-2.1 Feb 23, 2022
@live627 live627 added this to the 2.1.2 milestone Feb 23, 2022
@live627 live627 changed the title default value for credit column Explicitly define a default value for credits column in log_packages Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from pre 2.1 versions fails on PG
4 participants