Supports URLs with spaces in BBC params #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... despite proper standards and all better judgement. 馃槖 Signed-off-by: Jon Stovell <jonstovell@gmail.com>
|
I am having some serious issues testing this... (php 8.0, mysql 8.0) First problem: (Note I did have a language installed (albanian)...) So I figured maybe I installed the patch wrong? So I did a fresh install from current GH and got this. The installation couldn't complete... I was debating opening other issues, but these touch on the very functions in question here (iri_to_url). |
|
I think the const usages in class-Punycode.php need to reference self::, e.g., self::IDNA_ERROR_LABEL_TOO_LONG. I have confirmed if you make those changes to class-Punycode.php, links with spaces now work. |
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
Signed-off-by: Jon Stovell <jonstovell@gmail.com>
|
Better now, @sbulen? |
|
Yes, all errors appear to have been addressed, and URLs with spaces now work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... despite proper standards and all better judgement. 馃槖
Fixes #7441