Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$user->setupSession(); to wfSetupSession(); #1

Closed
jdarwood007 opened this issue Dec 8, 2011 · 2 comments
Closed

$user->setupSession(); to wfSetupSession(); #1

jdarwood007 opened this issue Dec 8, 2011 · 2 comments

Comments

@jdarwood007
Copy link
Member

According to Paracelsus, in MW 1.18, they changed the following code:

$user->setupSession();
$user->setCookies();

Will need to research this.

@Fustrate
Copy link
Contributor

Fustrate commented Dec 8, 2011

Not knowing mediawiki, there are two things that come to mind. Either use a version variable if MW provides one, or do a function_exists('wfSetupSession') and proceed from there. Do we know if $user->setCookies() also changed, probably to wfSetCookies()?

Also, is sm.org going to upgrade to 1.18, or is there a test installation somewhere? That would be the quickest way to solve this.

@jdarwood007
Copy link
Member Author

Well at least in 1.17 the method in the User class is as follows:

/**
 * @deprecated Use wfSetupSession().
 */
function SetupSession() {
    wfDeprecated( __METHOD__ );
    wfSetupSession();
}

So we should be able to safely replace this since it was finally removed.

Cookies have not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants