Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player/bot join/leave messages not filtered when using Bukkit #313

Open
ginbot86 opened this issue Oct 8, 2013 · 1 comment
Open

Player/bot join/leave messages not filtered when using Bukkit #313

ginbot86 opened this issue Oct 8, 2013 · 1 comment

Comments

@ginbot86
Copy link
Contributor

ginbot86 commented Oct 8, 2013

SimpleServer doesn't pick up the player join and leave messages when using Bukkit. Because of this, bot join and leave messages are forwarded to the client, rather than being suppressed.

This could either be just regex-check related or there could be a difference in the data structure of player join/leave messages between Bukkit and vanilla Minecraft; either way I haven't had a chance to determine the cause yet.

@iBotPeaches
Copy link
Member

Put a breakpoint on Line 236 of StreamTunnel.

Incoming messages are checked for JSON. If no containing JSON body is found it falls back to classic text, instead of treating as JSON.

If you just get me a dump of what is in the variable $message prior to line 237 running. I can track it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants