Game crashes with a "metric not found" error on song fail

[ElliottBelardo]

Specifically, it gives this error: Metric "PlayerStageStats::GradePercentFailed" could not be found in "Themes/Simply Love/metrics.ini"' or "Themes/_fallback/metrics.ini".

I was playing on SM 5.0.12, so I assume that could be the reason.

[quietly-turning]

It's true, that metric does not exist in this theme or _fallback. Can you tell me more about what settings you are using?

What is your fail type? What is your EventMode set to? PayMode? Etc.
The more specific you can be, the more likely it is that this will get fixed. :)

[ElliottBelardo]

• Event mode was on.
• Coin mode was set to Home.
• Fail type was set to Immediate, but I was able to reproduce the crash with fail type set to ImmediateContinue.

I assume that's all the important information needed.

[quietly-turning]

In that no one has ever reported this problem and I am unable to reproduce, it may take some time to figure what is different about your configuration that is causing StepMania to crash. Can you attach or upload a copy of the crashlog.txt that is generated by StepMania?

[ElliottBelardo]

log.txt

[quietly-turning]

Thanks. Unfortunately, I gleaned nothing from that other than the fact that you are using an older version of StepMania (5.0.12 when 5.1.0 is out) that I can test later.

I don't anticipate finding any problem there, however. What modifiers are you using? In particular, are you using the target score system? I didn't write that, don't know what it does or how it works, and wonder if there are possibly bugs lurking in it.

[ElliottBelardo]

The target score graph was enabled, and the target was set to PB. So I assume the target score was part of the issue, considering I hadn't set a score on the simfile I was playing yet. However, the game still crashes with the target score set to something other than the PB.

[ElliottBelardo]

Confirmed, the game doesn't crash (at least with the fail mode set to ImmediateContinue) with the target score system disabled. So now it's a matter of finding and fixing the bug causing the crash.

[quietly-turning]

This will be patched for the next release.

[quietly-turning]

@ElliottBelardo – Can you try changing this line so that it is wrapped in a check like this:

if currentGrade ~= "Grade_Failed" then
	self:queuecommand("GradeChanged")
end

Please let me know if that resolves the issue for you.

[quietly-turning]

@ElliottBelardo – Any update on this?

[ElliottBelardo]

I'm not entirely sure whether or not that fixed the bug. First, I tried the fix and it worked. Then, I played using the unfixed version, and it also worked (presumably because it already wrote the high score to the game data). So it's entirely possible that the game crash is caused by the game trying to call a nonexistent value (the personal record on the simfile). Other than that, I'd say the fix worked.

[quietly-turning]

Thanks for responding with this new information. I'll poke at it some more.

[quietly-turning]

This has (hopefully) been resolved for the v4.8 release. See d060363 for more detailed information.