Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch Clean-up #36

Closed
Simsso opened this issue Aug 29, 2018 · 5 comments
Closed

Branch Clean-up #36

Simsso opened this issue Aug 29, 2018 · 5 comments
Assignees
Labels
code Software is relevant or involved meta Meta information such as README updates and wiki edits

Comments

@Simsso
Copy link
Owner

Simsso commented Aug 29, 2018

I think we've got more branches than needed. Maybe it's time to clean things up a bit.

No high priority, just opening the issue for now.

@Simsso Simsso added code Software is relevant or involved meta Meta information such as README updates and wiki edits labels Aug 29, 2018
@ghost
Copy link

ghost commented Aug 30, 2018

Hey @Simsso , I'll merge tiny-imagenet-classifier-branch into training-enablement-tools and delete tiny-imagenet-classifier-branch and reference-cnn-branch as it would have all commits and changes of those. Furthermore I would merge deployment-pipeline-discussion (having some architecture pictures) into training-enablement-tools. So I'll clean those up from my side.

@Simsso
Copy link
Owner Author

Simsso commented Sep 2, 2018

Deleting layerwise-perturbation-experiments and linear-combination-experiments becuase both have been merged into experiments.

@Simsso
Copy link
Owner Author

Simsso commented Sep 4, 2018

Now that we have closed #29 and #31, shall we put the tiny-imagenet-classifier folder into the experiments folder in order to be able to delete the three branches

  • tiny-imagenet-classifier-resnet Updated 2 days ago by Simsso
  • tiny-imagenet-classifier-inception Updated a day ago by FlorianPfisterer
  • tiny-imagenet-classifier Updated a month ago by Simsso

I think it's a good habit not to delete any code permanently and not to have open branches which we'll never continue working on anyways. Opinions, @FlorianPfisterer @doktorgibson?
We'd have to add a nice README of course.

@FlorianPfisterer
Copy link
Collaborator

I agree we should keep the code but clean up the branches.
How would you merge our two branches (tiny-imagenet-classifier-resnet and tiny-imagenet-classifier-inception)? We have mostly worked in different files, but some of them are still different. Maybe create two subfolders of experiments - one for inception and one for resnet experiments? @Simsso

@ghost
Copy link

ghost commented Sep 5, 2018

Since I have already merged tiny-imagenet-classifier-resnet into training-enablement-tools for development purpose, you are completely free to delete those branches and decide for the best in your opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Software is relevant or involved meta Meta information such as README updates and wiki edits
Projects
None yet
Development

No branches or pull requests

2 participants