Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include iterator over all valid moves #132

Closed
SirRender00 opened this issue Oct 25, 2022 · 1 comment · Fixed by #172
Closed

Include iterator over all valid moves #132

SirRender00 opened this issue Oct 25, 2022 · 1 comment · Fixed by #172
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@SirRender00
Copy link
Owner

SirRender00 commented Oct 25, 2022

Should be able to do things like

  • (ActionType.RAISE, 50) in game.get_all_available_moves()
  • ActionType.CALL in game.get_all_available_moves()
  • (ActionType.CHECK, None) in game.get_all_available_moves()
  • (ActionType.CHECK, 50) in game.get_all_available_moves() # True
  • for action, val in game.get_all_available_moves(): print(action, val)

All in operations should be completed in O(1) time in the number of possible moves and chips.

@SirRender00 SirRender00 added the good first issue Good for newcomers label Oct 25, 2022
@SirRender00 SirRender00 added this to the v1.0.0 milestone Oct 25, 2022
@SirRender00 SirRender00 added the enhancement New feature or request label Oct 25, 2022
@SirRender00
Copy link
Owner Author

@gustavomfb Hey! Glad to have you interested in contributing to the package.

What were your thoughts on implementing this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants