Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for other languages #14

Closed
justchokingaround opened this issue Nov 22, 2022 · 12 comments
Closed

support for other languages #14

justchokingaround opened this issue Nov 22, 2022 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@justchokingaround
Copy link

image

For instance, russian characters don't render properly, and the program panicks when the user tries to input non english characters in the search query

@justchokingaround
Copy link
Author

the language displays just fine after video selection, it's just problematic when looking up something

@Siriusmart
Copy link
Owner

A few questions:

  1. Does the program exit or does it just freaks out?
  2. Which terminal emulator are you using?
  3. Does it still happens after setting images to None in ~/.config/youtube-tui/main.yml?

Because characters are difficult in Rust, especially in languages where you got multiple characters somehow merges into another character.

@Siriusmart Siriusmart added the bug Something isn't working label Nov 26, 2022
@Siriusmart Siriusmart self-assigned this Nov 26, 2022
@justchokingaround
Copy link
Author

  1. panicks and exits
  2. foot, but same behavior on alacritty and kitty
  3. yes

sorry for the very late response, love your project and i really appreciate the effort you put into it

@odyxz
Copy link

odyxz commented Nov 28, 2022

Same issue. There's problem in tui-additions.

image

@Siriusmart
Copy link
Owner

check updated version, this should be fixed

@justchokingaround
Copy link
Author

can confirm it works, ty 👍

@odyxz
Copy link

odyxz commented Nov 28, 2022

Now i can write cyrillic letters, but in selection menu they didn't showed. In preview section it is.

image

@Siriusmart
Copy link
Owner

That is because allow_unicode is false in main.yml

There used to be an issue with the text list displaying unicode, but now it doesnt seem to exist anymore and unicode is enabled by default

alternatively you can delete config files to regenerate them

@odyxz
Copy link

odyxz commented Nov 28, 2022

That's works. Thank you much :) It's the best youtube ncurses client!

@odyxz
Copy link

odyxz commented Nov 28, 2022

Only one problem remains.

image

It's showing when open any live streams.

@Siriusmart
Copy link
Owner

that seems to be a problem on the invidious crate, gonna fix it when i have time

@Siriusmart
Copy link
Owner

created this issue for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants