hooks: add airbrake hook

[sirupsen]

This adds an Airbrake default hook. I would've liked to have put this in its own directory inside logrus, but I'm getting a cycle dependency warning. It sucks if everyone has to install the Airbrake library because of this..

@snormore @burke @aybatme can you guys take a look?

[sirupsen]

Oops, typoed @aybabtme

[aybabtme]

Hey, just saw that. I'll have a look tomorrow.

[burke]

👍

[sirupsen]

Did you guys have an idea on how to move this out of the main install so not everyone has to install the Airbrake library for example?

[Soulou]

The first solution I can see is build tags

aibrake_hook.go

// +build airbrake

package logrus

[...]

Then

• go get -tags airbrake
• go build -tags airbrake

[sirupsen]

I didn't know about build tags, that's cool! I might go ahead with that :-)

[aybabtme]

Why not make the airbrake hook a separate package? It seems odd to be baked into the library.

[aybabtme]

Like, move it into some folder (or another repo of common hooks, or where ever else not in the same namespace):

% pwd
$GOPATH/github.com/Sirupsen/logrus/hooks/airbrake
% head airbrake.go
package airbrake

import (...) 

type AirbrakeHook struct {...}

// implement logrus.Hook

func Hook(authStuff ...) *AirbrakeHook {
    return &AirbrakeHook{...}
}

Then:

log := logrus.New()
log.Hooks.Add(airbrake.Hook(...))

On a side note, I dislike build tags.

[Soulou]

I think I prefer @aybabtme solution (Even if I've personnaly given the other one ;-) ) It's cleaner to separate things and more than that, using build tags is a bit annoying, when you take a golang project, usually you want to "go get" it, and nothing else.

I event would have done something like having a hooks directory in which you put other packages like airbrake, rollbar, or sentry. Managing another repository for each hooks can look "heavy" but it's what's happening with different projects (example https://github.com/martini-contrib)

[sirupsen]

Yeah, a different repo with subfolders sounds good to me. I like that separation of concerns. I dislike having a repo for each one of them. I'll go ahead with that :-)

[aybabtme]

👍

[sirupsen]

It's in the logrus-hooks repo, I'll update the readme laters