Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputListener change event for Editor does not pass column to handler #1113

Closed
schallm opened this issue Apr 1, 2015 · 1 comment
Closed

Comments

@schallm
Copy link
Contributor

schallm commented Apr 1, 2015

The column variable is not provided when calling _handleEditorChange in the main InputHandler within Editor.js (version 0.4):

this.on('change', function (evt) {
     self._handleEditorChange(evt);
});

The column is already available and is passed in the IE specific events. It should look like the following:

this.on('change', function (evt) {
     self._handleEditorChange(evt, column);
});
@kfranqueiro
Copy link
Contributor

This won't actually work, because this code registers a single delegated event listener for the entire grid - not one per column. The old-IE case is special in that it is registering event handlers on each individual input.

The code in _handleEditorChange already looks up the column itself from the event target, so the old-IE branch passing column is really just a shortcut to avoid that overhead when it's already known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants