Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown characters in GlobalSuppression.cs files #2

Open
brianhdk opened this issue Mar 16, 2016 · 7 comments
Open

Unknown characters in GlobalSuppression.cs files #2

brianhdk opened this issue Mar 16, 2016 · 7 comments

Comments

@brianhdk
Copy link

This might be a local issue, but I've tried to clone the repository on different machines, and on every machine I'm unable to build the solution, because of strange chinese-looking characters in the GlobalSuppresion.cs file.

See the following screen-shot from VS: https://dl.dropboxusercontent.com/u/4142207/globalsuppression.JPG

Have you guys experienced this before - or know how to solve it?

It's the same issue if I download the ZIP file containing the source code. But the issue is not present in the previous release. Hope it helps.

Thanks

@brianhdk brianhdk changed the title Unknown characters on GlobalSuppression Unknown characters in GlobalSuppression.cs files Mar 16, 2016
@brianhdk
Copy link
Author

@SorenKerrn
Copy link
Collaborator

It's not a known issue or something we have seen before. We will try it out and see if we can reproduce the issue

@SorenKerrn
Copy link
Collaborator

As it turns out, we have seen it on same instances and it seems to be GIT related. We have provided a PowerShell script that can help you out. It's located with the release and named UnixToWindowsEOL.zip.
And you will likely encounter more instances than the GlobalSuppresion.cs file, which the script will fix

@larrelandin
Copy link

@SorenKerrn That script seems to be designed only for items handled by TDS. This is another problem I am afraid.

@DThrasher
Copy link

I think the bad characters have been checked into the repository somehow. I ran the UnixToWindowsEOL.ps1 conversion script with the following parameters:

..\UnixToWindowsEOL.ps1 -path 'C:\Projects\Reference-Storefront' -include 'GlobalSuppressions.cs'

But this did not resolve the issue. The earlier stackoverflow issue referenced by @brianhdk is spot on; it's definitely a UTF16LE encoding issue.

@SorenKerrn
Copy link
Collaborator

We will take a look at it and make sure that the checked in source is in the correct format

@SorenKerrn
Copy link
Collaborator

A new version of the source code files was pushed to the repository where the file formats have been fixed. It's tagged 8.1.478.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants