Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediaApi.updateImageUrl loses revision querystring #172

Closed
jeppeskovsen opened this issue Apr 4, 2019 · 3 comments
Closed

mediaApi.updateImageUrl loses revision querystring #172

jeppeskovsen opened this issue Apr 4, 2019 · 3 comments

Comments

@jeppeskovsen
Copy link

Description

When we use mediaApi.updateImageUrl function to set sizes, it loses the rev querystring.

Expected behavior

It should keep the rev querystring to properly invalidate CDN cache when updated.

@paulmains
Copy link

I've just discovered this issue. As a workaround i'm currently overriding the mediaApi to accommodate the revision querystring. It would be be great if this one could be remedied.

@sc-dawidrutkowski
Copy link
Contributor

Fixed in #275

@ssartell
Copy link

ssartell commented Aug 7, 2020

I think the fix for this issue is causing me issues now. I want to pass the original src for the image and sizing params to get a new src, but the original src includes w, h, iar, and hash by default from Sitecore (w and h are set to the original size of the image). I can't clear them off without manipulating the src before passing it in. The original implementation of this method would be correct for me. As it stands, the allowlist has to be different than what I pass into the Image component imageParams prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants