Optimized searching for specified colors in image_recognition.py with cv::inRange()

[ComictypX]

Iterating through a Python array with two nested for-loops is not as fast as openCV/Numpy can do it vectorized.
Therefore, I replaced the two for-loops by the OpenCV function cv::inRange() and the python array given by PIL with a numpy one.

I tried my best measuring the improvements with measuring the execution time of call_appropriate_fishing_action():

Before: ~0,3534 seconds
After: ~0,09526 seconds
== 3,71 times faster (median average bit smaller: 3,62)

Just the color finding part without template matching is ~175 - 200 times faster.

Another Upside: we now have all the color matching pixels and could do some math on them to get the area, e.g. for optimized reeling (all white pixels in mask).

[Siterizer]

@ComictypX Wow, i did not know that cv2 has such a functions XD. Thank you very much, i will try to test it and give you an feedback

[53m1k0l0n]

Tested this. Works really well and fast. Good work thank you.

[4rak007]

Iterating through a Python array with two nested for-loops is not as fast as openCV/Numpy can do it vectorized. Therefore, I replaced the two for-loops by the OpenCV function cv::inRange() and the python array given by PIL with a numpy one.

I tried my best measuring the improvements with measuring the execution time of call_appropriate_fishing_action():

Before: ~0,3534 seconds After: ~0,09526 seconds == 3,71 times faster (median average bit smaller: 3,62)

Just the color finding part without template matching is ~175 - 200 times faster.

Another Upside: we now have all the color matching pixels and could do some math on them to get the area, e.g. for optimized reeling (all white pixels in mask).

Hello, Which file did u edit ? and if u could upload the file would be nice ty .

[53m1k0l0n]

Iterating through a Python array with two nested for-loops is not as fast as openCV/Numpy can do it vectorized. Therefore, I replaced the two for-loops by the OpenCV function cv::inRange() and the python array given by PIL with a numpy one.
I tried my best measuring the improvements with measuring the execution time of call_appropriate_fishing_action():
Before: ~0,3534 seconds After: ~0,09526 seconds == 3,71 times faster (median average bit smaller: 3,62)
Just the color finding part without template matching is ~175 - 200 times faster.
Another Upside: we now have all the color matching pixels and could do some math on them to get the area, e.g. for optimized reeling (all white pixels in mask).

Hello, Which file did u edit ? and if u could upload the file would be nice ty .

Look here: xD
Files

[raverecursion]

Can confirm, huge performance improvement. Today we eat oysters for dinner 😎

[Logonius]

It does not work for me, it throws it, but it catches nothing and does not pull the line. I don’t even know, the code was copied exactly.

[raverecursion]

I don’t even know, the code was copied exactly.

The answer is probably in your comment

[Logonius]

Checked all 10 times, every line, no errors.
And he also leaves the game in the AFK, it is no longer possible to catch.

[raverecursion]

Checked all 10 times, every line, no errors. And he also leaves the game in the AFK, it is no longer possible to catch.

Copy and replace the code from here:

https://raw.githubusercontent.com/Siterizer/new-world-fishing-bot/646cc7f0dbcdac65e5312e12bfc4d9b84da60917/functionality/image_recognition.py

If it's not working, dunno

[Logonius]

Yes, I copied from here, there can be no mistakes, but he does not hook or pull anything. ¯_(ツ)_/¯

[ComictypX]

@Logonius are you running your game still in 1080p? What is the bot logging to console? Only "[INFO] Cast fishing rod" ?

[SynaX1]

Yes, I copied from here, there can be no mistakes, but he does not hook or pull anything. ¯_(ツ)_/¯

yeah.. i do the same, with the same result, not pulling

[Mpaulo]

is working for me, i'll do more tests to see, but it really is better

[RobertMCortese]

@ComictypX Can you build and put up in your repository so I can test?

[ComictypX]

@RobertMCortese https://github.com/ComictypX/new-world-fishing-bot/releases/tag/v1.2.1

[mitmiisnix]

Works great!

[aim2kill]

from reeling at 1/2 when to 1/4 ish

[ITgamers]

Is this something that has been added to your updated version or is it something that I need to update manually ? Thank you all for all you smart brains.. can't wait to learn. Python in a couple weeks for a college class 👍

[ComictypX]

@ITgamers If you download it from my "BetterColorSearch" branch it will be included. Otherwise you should use the release in my repo or patch the image_recognition.py manually :)

[Siterizer]

Sorry, end of the support. Statement:
https://github.com/Siterizer/new-world-fishing-bot#new-world-fishing-bot-end-of-support