Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Use protobuf-java-util for protobuf parsing (to and from JSON) #53

Merged
merged 5 commits into from Sep 7, 2017
Merged

Use protobuf-java-util for protobuf parsing (to and from JSON) #53

merged 5 commits into from Sep 7, 2017

Conversation

tomasulo
Copy link
Contributor

@tomasulo tomasulo commented Sep 5, 2017

Description of the Change

I propose to use http://mvnrepository.com/artifact/com.google.protobuf/protobuf-java-util for parsing protobuf messages to and from JSON instead of a combination of self-written code and http://mvnrepository.com/artifact/com.googlecode.protobuf-java-format/protobuf-java-format.

Benefits

  • Exchanging protobuf-java-format (is not being maintained anymore, last release: November 2015) with the actively maintained protobuf-java-util
  • protobuf-java-util provides standardized serialization and deserialization
  • version of protobuf-java-util matches the protobuf version we use in the projects
  • using official code published by google instead of our own version

Possible Drawbacks

None, as far as I know.

@bkrahmer
Copy link
Contributor

bkrahmer commented Sep 5, 2017

Thomas, I think the implementation looks great. I think we need some more test cases before I'd be comfortable merging it, however. enums, byte strings and sub-messages are my main concerns.

@tomasulo
Copy link
Contributor Author

tomasulo commented Sep 5, 2017

Okay, I will add some more testcases.

@bkrahmer bkrahmer merged commit 6564de3 into Sixt:master Sep 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants