Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stick to the concrete linter version #312

Closed
zhenik opened this issue Sep 10, 2020 · 6 comments · Fixed by #425
Closed

Stick to the concrete linter version #312

zhenik opened this issue Sep 10, 2020 · 6 comments · Fixed by #425
Labels
stage/blocked This issue is blocked theme/ci Related to build, test, and release pipeline

Comments

@zhenik
Copy link
Contributor

zhenik commented Sep 10, 2020

Originally posted here

@zhenik zhenik added the theme/ci Related to build, test, and release pipeline label Sep 10, 2020
@zhenik zhenik added this to the 0.4.1 milestone Sep 10, 2020
@Neha-Sinha2305
Copy link
Contributor

@zhenik :Which version of super-linter should we use?
https://github.com/github/super-linter/releases

@zhenik
Copy link
Contributor Author

zhenik commented Sep 11, 2020

@Neha-Sinha2305
Copy link
Contributor

@zhenik : Should i include this hotfix solution in these files too to have a consistent implementation for now:

Note: Risk of not doing this will be that the hotfix in submodules will get overriden once we resynch the submodules with vagarant-hashistack-template latest code.

@zhenik
Copy link
Contributor Author

zhenik commented Sep 11, 2020

I would suggest to do not add it. Modules maintainers will know it by new PR :) Believe me, like me here Skatteetaten/terraform-nomad-trino#9

@Neha-Sinha2305
Copy link
Contributor

I would suggest to do not add it. Modules maintainers will know it by new PR :) Believe me, like me here fredrikhgrelland/terraform-nomad-presto#9

sure..i will pick up some other task then.
I will get back to this issue when github/super-linter#708 is fixed.

@Neha-Sinha2305 Neha-Sinha2305 added the stage/blocked This issue is blocked label Sep 11, 2020
@Neha-Sinha2305 Neha-Sinha2305 self-assigned this Sep 11, 2020
@Neha-Sinha2305 Neha-Sinha2305 removed their assignment Oct 7, 2020
@fredrikhgrelland fredrikhgrelland linked a pull request Oct 21, 2020 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/blocked This issue is blocked theme/ci Related to build, test, and release pipeline
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants