Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deprecation): prefer request.routeOptions.method over request.routerMethod #93

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

juleswritescode
Copy link
Contributor

@juleswritescode juleswritescode commented Oct 30, 2023

Hey Sir!

Awesome library. Thank you for maintaining it!

This PR should fix Issue #90 .
It's my first open source contribution, I hope I followed all the rules.

@SkeLLLa
Copy link
Owner

SkeLLLa commented Oct 31, 2023

Amazing, thanks.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de6a03c) 100.00% compared to head (dcaf232) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #93   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          155       157    +2     
  Branches        58        60    +2     
=========================================
+ Hits           155       157    +2     
Files Coverage Δ
src/fastify-metrics.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkeLLLa SkeLLLa merged commit f8d5ed3 into SkeLLLa:master Oct 31, 2023
6 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
## [10.3.3](v10.3.2...v10.3.3) (2023-10-31)

### 🛠 Fixes

* **deprecation:** prefer request.routeOptions.method over request.routerMethod ([#93](#93)) ([f8d5ed3](f8d5ed3))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 10.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants