Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of sinon is breaking the build 🚨 #58

Closed
greenkeeper bot opened this issue Jul 26, 2017 · 2 comments
Closed

An in-range update of sinon is breaking the build 🚨 #58

greenkeeper bot opened this issue Jul 26, 2017 · 2 comments

Comments

@greenkeeper
Copy link

greenkeeper bot commented Jul 26, 2017

Version 2.4.0 of sinon just got published.

Branch Build failing 🚨
Dependency sinon
Current Version 2.3.8
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As sinon is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details
  • coverage/coveralls First build on greenkeeper/sinon-2.4.0 at 100.0% Details
  • continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 11 commits.

  • 20eb865 Update docs/changelog.md and set new release id in docs/_config.yml
  • e333e75 Add release documentation for v2.4.0
  • fde7911 2.4.0
  • 9afdcfc Update Changelog.txt and AUTHORS for new release
  • 57bb8b3 Merge pull request #1489 from Rowno/named-anonymous-mocks
  • c9a35ef Update fake-xhr-and-server.md
  • 837ec0c Allow anonymous mock functions to be named
  • 259a330 Merge pull request #1481 from fatso83/fix-safari-breaking
  • e742268 Merge pull request #1488 from VynceMontgomery/patch-1
  • a6a2b8c Clarify behavior of useFakeTimers
  • 24d15f2 Avoid running test for #1456 on Safari

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Author

greenkeeper bot commented Jul 26, 2017

After pinning to 2.3.8 your tests are passing again. Downgrade this dependency 📌.

@colestrode
Copy link
Member

This was a false positive due to an error uploading coverage to coveralls. I re-ran this morning and the build is green: https://travis-ci.org/Skellington-Closet/skellington/builds/257602571.

Also... greenkeeper is awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant