Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bucklescript's compiler to a worker thread #235

Closed
thangngoc89 opened this issue Jul 31, 2019 · 3 comments
Closed

Move bucklescript's compiler to a worker thread #235

thangngoc89 opened this issue Jul 31, 2019 · 3 comments
Labels
e/bucklescript Bucklescript engine related issues good first issue Good for newcomers P/1 Extremely critical. Need to fix this ASAP
Milestone
Bucklescript beta...

Comments

@thangngoc89
Copy link
Member

thangngoc89 commented Jul 31, 2019 •
edited

Benefits:

  • Don't block the main UI thread
  • Got synchronous function importScript to load new stuff into the environment

Consider promise-worker 's API style which is less verbose and easy to use.
@thangngoc89 thangngoc89 added e/bucklescript Bucklescript engine related issues P/2 Acknowledged. There is a bug but it won't break the whole thing labels Jul 31, 2019
@thangngoc89
Copy link
Member Author

Move this to P/1 . After adding ReasonReact, the response time is pretty terrible, the main thread freezes after each character

Demo:

https://sketch-git-reason-react.sketch-sh.now.sh/

@thangngoc89 thangngoc89 added P/1 Extremely critical. Need to fix this ASAP and removed P/2 Acknowledged. There is a bug but it won't break the whole thing labels Jul 31, 2019
@thangngoc89 thangngoc89 added this to the Bucklescript launch milestone Jul 31, 2019
@thangngoc89
Copy link
Member Author

image

@thangngoc89 thangngoc89 added the good first issue Good for newcomers label Jul 31, 2019
@jchavarri
Copy link
Contributor

BuckleScript does not exist anymore and I don't think we will have the resources to build a brand new Sketch engine for ReScript anytime soon, so closing related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e/bucklescript Bucklescript engine related issues good first issue Good for newcomers P/1 Extremely critical. Need to fix this ASAP
Projects
None yet
Milestone
Bucklescript beta launch
Development

No branches or pull requests
2 participants
@jchavarri @thangngoc89