Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketchup::Model::get_product_family #163

Open
DanRathbun opened this issue May 19, 2017 · 3 comments
Open

Sketchup::Model::get_product_family #163

DanRathbun opened this issue May 19, 2017 · 3 comments

Comments

@DanRathbun
Copy link

Should Sketchup::Model::get_product_family be marked as deprecated ?

I have a report that SketchUp 2015 Make is reporting 2 (pro) as a result of calling this method.

I remember reporting bugs in this method some versions back, and I thought that they were addressed. But perhaps still bugged in v2015 ?

If so perhaps a note should be added to the docs about bugged versions ?

P.S. - FTR this method should not have been an instance method nor defined within the Sketchup::Model class.

@thomthom
Copy link
Member

P.S. - FTR this method should not have been an instance method nor defined within the Sketchup::Model class.
Yes, it is misplaced. This method is troublesome. Might be best to deprecate it and introduce a new one going forward.

@DanRathbun
Copy link
Author

DanRathbun commented Oct 30, 2017

@thomthom Yes, it is misplaced. This method is troublesome. Might be best to deprecate it and introduce a new one going forward.

Agree best choice. Such a important query method should have been within the Sketchup::Licensing module, which should be frozen.

When I reported the previous bugs, I suggested the old method be aliased to the new locked method.

@DanRathbun
Copy link
Author

@thomthom Might be best to deprecate it and introduce a new one going forward.

With the discontinuance of Make edition development (2018) the use of this old method is greatly reduced. This makes it a good time to deprecate the old method and create a new one.

New API Issue logged ...

@thomthom thomthom transferred this issue from SketchUp/ruby-api-stubs Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants