likely fix for strange error with gcc <= 9 #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gcc 9 and the code wouldn't compile due to a different gelu() function interface; a
bool
parameter is passed for gcc <= 9.I checked the torch source and saw a new parameter was added to gelu() in torch 12 (currently looks almost through release candidates, can be installed from the nightlies with something like
pip3 install --pre torch\<1.13 --extra-index-url https://download.pytorch.org/whl/nightly/cu113
). It was documented in the commit logs as a boolean for approximation, but it appears to be a string in the actual source.I'm guessing this slipped by tests because gcc > 9 was used for testing.
I mutated the check to check for torch >= 1.12 instead, and change the boolean
true
to a string"tanh"
which I think is what torch 12 expects.The code sequence seems very strange, and I'm curious if it was made by some AI refactoring tool. I don't use one, so I'm always looking to learn if there's a good one.