Implement fetching employees via the custom report endpoint

[artfuldodger]

Using the custom report endpoint allows us to get a list of the employees with any fields we want in a much more performant manner than iterating through all the employees and getting additional information one-by-one.

[coveralls]

Coverage increased (+0.7%) to 92.731% when pulling a9be276 on bonusly:custom-reports into 0986b25 on Skookum:master.

[coveralls]

Coverage increased (+0.7%) to 92.731% when pulling 02bfa9e on bonusly:custom-reports into 0986b25 on Skookum:master.

[robertIngrum]

Definitely seems like a nice improvement!

[splybon]

hey @artfuldodger saw your comment in the other PR and this is looking good. Can you fix some of the rubocop errors here? You can click details in the travis-ci checks, or click the link below

https://travis-ci.org/Skookum/bamboozled/jobs/496020015

[artfuldodger]

@splybon I rebased off develop and took care of most of the Rubocop issues. For the remaining issue: I find listing one attribute per line in all_names preferable to having everything on one line (improves, for example, seeing the diff when something changes), so I'm not sure if anything should actually change there. Happy to tweak to match your preferences though.

[splybon]

@artfuldodger I totally agree.

Can you disable that rubocop error then so the linter passes CI?
If you add a comment on or above the method line like below:
# rubocop:disable Metrics/MethodLength

[artfuldodger]

@splybon Done! Looks like we're all green now.