Transformations

[enriikke]

• Finally added the document transformation code!!
• Updated SkoogleDocs::Document class to use the new SkoogleDocs::Transformer
• Disabled RSpec monkey patching
• Included tests and documentation

[coveralls]

Coverage increased (+0.65%) to 95.85% when pulling 2ded516 on transformations into 7979687 on master.

[ruprict]

so, I can't overwrite? What about using mocks in tests?

[chuckpreslar]

I agree with @ruprict, here. Maybe we could change this declaration to

def transformer(klass = SkoogleDocs::Transformer)
  klass.new(@source)
end

[enriikke]

I agree. Thank you both for giving me input on this. I'll change the code to reflect this.
@chuckpreslar is there a difference between defaulting to an actual instance of SkoogleDocs::Transformer instead of the class?

[chuckpreslar]

using the class allows for a smaller duck-typed interface the class must implement (only new here) and more control to allow the transformer method to function as a factory.

for a hypothetical example, let's say we pass in instances. if the instance we pass it has already been configured with default values, the ability for transformer to manipulate the instance without potentially breaking things is limited.

[ruprict]

Looks really good. I especially like the use of FactoryGirl for the HTML docs. Just had one very minor comment, otherwise

[chuckpreslar]

very nice, @enriikke

[coveralls]

Coverage increased (+3.2%) to 98.4% when pulling f6e0d25 on transformations into 7979687 on master.

[coveralls]

Coverage increased (+0.65%) to 95.85% when pulling f6e0d25 on transformations into 7979687 on master.