Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with wheat (item) #1664

Closed
iOshawott opened this issue Nov 6, 2018 · 3 comments
Closed

Issue with wheat (item) #1664

iOshawott opened this issue Nov 6, 2018 · 3 comments
Labels
aliases For mistakes or requested additions in the aliases themselves, not the code driving the aliases. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Comments

@iOshawott
Copy link

iOshawott commented Nov 6, 2018

[18:35:28] [Server thread/ERROR]: [Skript] can't understand this condition: 'player have 64 wheat' (wq1.sk, line 520: if player have 64 wheat:')

code:

on rightclick on player:
  if name of event-entity is "&eGornik":
    if {qf::%player%} is "0.41":
      if player have 64 wheat:
        remove 64 wheat from player's inventory
        add 16 diamond to player's inventory

skript version: beta-2 (latest)
server paper-424 (1.13.2)

@ShaneBeee
Copy link
Contributor

It could be due to the fact that wheat is in the aliases as wheat item

wheat item¦s = minecraft:wheat

@TheBentoBox TheBentoBox added enhancement Feature request, an issue about something that could be improved, or a PR improving something. aliases For mistakes or requested additions in the aliases themselves, not the code driving the aliases. labels Nov 6, 2018
@TheBentoBox
Copy link
Member

Yeah, the aliases here could use some improvement. It's a bit strange because there's no "right answer" about how aliases should be structure; should just wheat refer to the item, or the block? Maybe neither, and you always have to specify if you mean the wheat item or block? Or should it refer to an alias group (such as [any] wheat = wheat item, wheat plant) and then if you want to reference a specific one (just the item or block) you have to append "item" or "block/plant" to the alias? This applies to many other items too and they're all valid answers.

Regardless, I'll take a look at the wheat aliases and any others that may have similar issues as soon as I can. Open to feedback based on the above examples.

@TheBentoBox
Copy link
Member

The item part of the wheat item alias is now optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aliases For mistakes or requested additions in the aliases themselves, not the code driving the aliases. enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

No branches or pull requests

3 participants