Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Villager races #2179

Open
3 tasks
Misio12320 opened this issue Jun 19, 2019 · 5 comments
Open
3 tasks

Villager races #2179

Misio12320 opened this issue Jun 19, 2019 · 5 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@Misio12320
Copy link

Misio12320 commented Jun 19, 2019

Hey I have some suggsstions.

  • Add villager's race in mean if villager is: ice villager or tayga villager or savanna villager:
    a. [Bento comment] This would be a 1.14-specific expression via this method.
  • If work of villager is: armourer etc.
  • If player don't have permission make villager more cost. Have I to explain smt from this?
    a. [Bento comment] Potentially more support for the villager and merchant Bukkit APIs.
@FranKusmiruk
Copy link
Member

  1. Bukkit doesn't offer any methods to identify this, you could work it around by checking the biome at the villager's location.
  2. This is already possible, if event-villager is armorer:
  3. Not totally sure what you're asking here but it seems like something you could make with Skript. The plugin itself doesn't offer any features alone, it just provides the syntaxes to do so.

@TheBentoBox
Copy link
Member

Bukkit doesn't offer any methods to identify this, you could work it around by checking the biome at the villager's location.

That isn't true, in 1.14 villagers have a getVillagerType which returns a Villager.Type.

Not totally sure what you're asking here but it seems like something you could make with Skript. The plugin itself doesn't offer any features alone, it just provides the syntaxes to do so.

They're asking for a way to change trading costs based on a permission. We shouldn't implement that so explicitly but Skript itself is basically entirely missing any support for the entire villager and merchant API.

@TheBentoBox TheBentoBox added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Jun 19, 2019
@Moderocky
Copy link
Member

Moderocky commented Jun 23, 2019

They're asking for a way to change trading costs based on a permission. We shouldn't implement that so explicitly but Skript itself is basically entirely missing any support for the entire villager and merchant API.

The part you're looking for in terms of #3 is the price multiplier. Since Skript currently has nothing added in terms of merchant recipes, this would require a bit of work.
Sadly, due to how price multipliers are implemented in Minecraft it would be quite difficult to (safely) make a permission-based trade price.

@Wealthyturtle Wealthyturtle changed the title Villager suggestion Villager races Oct 17, 2019
@Matocolotoe

This comment has been minimized.

@Misio12320

This comment has been minimized.

@TPGamesNL TPGamesNL added the PR available Issues which have a yet-to-be merged PR resolving it label Mar 23, 2021
@TheLimeGlass TheLimeGlass added priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). and removed priority: low Issues that are not harmful to the experience but are related to useful changes or additions. PR available Issues which have a yet-to-be merged PR resolving it labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

7 participants