Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Paper mc api changed: tests fail #4439

Closed
1 task done
Olyno opened this issue Nov 24, 2021 · 1 comment
Closed
1 task done

CI Paper mc api changed: tests fail #4439

Olyno opened this issue Nov 24, 2021 · 1 comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. unit testing For issues/PRs related to the Skript unit testing system.

Comments

@Olyno
Copy link
Contributor

Olyno commented Nov 24, 2021

Skript/Server Version

/

Bug Description

Because the paper api changed, tests in the ci now fail. Infos: https://github.com/SkriptLang/Skript/runs/4316945484?check_suite_focus=true#step:5:22

Expected Behavior

Tests of CI should still work.

Steps to Reproduce

Simply make a pr

Errors or Screenshots

https://github.com/SkriptLang/Skript/runs/4316945484?check_suite_focus=true#step:5:22

Other

No response

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Nov 24, 2021 •
edited

New link syntax: https://papermc.io/api/v2/projects/paper/versions/1.12.2/builds/1618/downloads/paper-1.12.2-1618.jar

Useful links:
https://papermc.io/api/v2/projects/paper/versions/1.12.2
https://papermc.io/api/v2/projects/paper/versions/1.12.2/builds/1618
https://papermc.io/api/v2/projects/paper/versions/1.12.2/builds/1618/downloads/paper-1.12.2-1618.jar

Same for other versions

All json files here new to update

@AyhamAl-Ali AyhamAl-Ali mentioned this issue Nov 25, 2021
Merged
@ShaneBeee ShaneBeee added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. PR available Issues which have a yet-to-be merged PR resolving it labels Nov 26, 2021
@TPGamesNL TPGamesNL added completed The issue has been fully resolved and the change will be in the next Skript update. unit testing For issues/PRs related to the Skript unit testing system. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. unit testing For issues/PRs related to the Skript unit testing system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ShaneBeee @AyhamAl-Ali @Olyno @APickledWalrus @TPGamesNL