Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for double pound symbol #5181

Open
1 task done
Fusezion opened this issue Oct 26, 2022 · 4 comments
Open
1 task done

Error message for double pound symbol #5181

Fusezion opened this issue Oct 26, 2022 · 4 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@Fusezion
Copy link
Contributor

Fusezion commented Oct 26, 2022

Suggestion

Update error message for using "#" inside strings *or maybe find a way to exclude comments while inside strings.
The current error message for when you do "Stringy text #thingy" isn't clear as it defaults to " see image below *taken from discord*

Why?

I believe the current error message leads to too many miss understandings in errors since you'll check " right away
Since when you read it you'll think it should be like ""Stringy text #thingy"" which leads to a new error

Other

image

While I'm not sure how hard it would be to make # excluded in strings I believe it's something that's better than simply making a new error message but leads to breaking changes Since when using hex codes we have to do <##ff0000> which isn't nice looking to new people in skript

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@TheLimeGlass
Copy link
Collaborator

You have to double the pound symbol.

@TheLimeGlass TheLimeGlass added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Oct 26, 2022
@Fusezion Fusezion changed the title Change double quote error message Error message for double pound symbol Oct 27, 2022
@Fusezion
Copy link
Contributor Author

You have to double the pound symbol.

While true it's mostly the fact there's no error for invalid use of #. Most people new to skript don't understand the current error
and I believe it might be a good idea to see if we could remove the need of double pound and double percent symbols.

And if not then simply adding an error message for double pound is good since we already got one for percents and quotes

@TheLimeGlass
Copy link
Collaborator

Duplicate #1211

@TheLimeGlass TheLimeGlass added duplicate For bugs or requests that have already been made and are currently open. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels May 30, 2023
@sovdeeth
Copy link
Member

this is not a duplicate of #1211, 1211 is about comments starting with multiple #, not about a bad error message when forgetting to double # in a quoted string.

@sovdeeth sovdeeth reopened this Apr 18, 2024
@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). and removed duplicate For bugs or requests that have already been made and are currently open. labels Apr 18, 2024
@sovdeeth sovdeeth added the PR available Issues which have a yet-to-be merged PR resolving it label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. PR available Issues which have a yet-to-be merged PR resolving it priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

3 participants