Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挕 Correct Javadocs name, title #5984

Closed
1 task done
AyhamAl-Ali opened this issue Sep 9, 2023 · 12 comments
Closed
1 task done

馃挕 Correct Javadocs name, title #5984

AyhamAl-Ali opened this issue Sep 9, 2023 · 12 comments
Assignees
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. documentation Related to Skript's official documentation. enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for

Comments

@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Sep 9, 2023

Suggestion

Skript Javadocs should be named Skript $VERSION$ e.g. Skript 2.7.0
https://docs.skriptlang.org/javadocs/

Name
image

Webpage Title
image

Why?

cuz we cool

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@AyhamAl-Ali AyhamAl-Ali added enhancement Feature request, an issue about something that could be improved, or a PR improving something. documentation Related to Skript's official documentation. good first issue An issue that would be good for a first-time contributor to make a PR for labels Sep 9, 2023
@MihirKohli
Copy link
Contributor

Can you assign me this issue?

@Moderocky
Copy link
Member

While we're here, are you aware you can change the styling of the javadocs template so it doesn't look like it arrived here in a time machine from 2003?

If you are interested in making it not look the way it does, let me know and I can show you how to build it with a special stylesheet.

Below is a simple example with the colours changed; you could do the same in Skript's colour scheme
image

You are, of course, able to make much larger changes to the styling but remember that the layout and the files are procedurally-generated, so you must work with what you are given.

@MihirKohli
Copy link
Contributor

MihirKohli commented Sep 15, 2023

While we're here, are you aware you can change the styling of the javadocs template so it doesn't look like it arrived here in a time machine from 2003?

If you are interested in making it not look the way it does, let me know and I can show you how to build it with a special stylesheet.

Below is a simple example with the colours changed; you could do the same in Skript's colour scheme image

You are, of course, able to make much larger changes to the styling but remember that the layout and the files are procedurally-generated, so you must work with what you are given.

Is it possible to make changes in all the instance at once? Making all pages have common header & favicon?

@Moderocky
Copy link
Member

Is it possible to make changes in all the instance at once? Making all pages have common header & favicon?

Possibly, Maven comes with a built-in plugin for manipulating javadocs but Skript uses gradle and I don't know what the equivalent is for that. You might have to google it :)

@MihirKohli
Copy link
Contributor

Updated Changes required for Homepage
SkriptLang/skript-docs#50

@MihirKohli
Copy link
Contributor

image

@MihirKohli
Copy link
Contributor

Is it possible to make changes in all the instance at once? Making all pages have common header & favicon?

Possibly, Maven comes with a built-in plugin for manipulating javadocs but Skript uses gradle and I don't know what the equivalent is for that. You might have to google it :)

Btw i am interested in building as you have mentioned above

@MihirKohli
Copy link
Contributor

How to add favicon couldn't find any reference @AyhamAl-Ali ?

@AyhamAl-Ali
Copy link
Member Author

How to add favicon couldn't find any reference @AyhamAl-Ali ?

Based on my quick research (with help of ChatGPT as well), you can do that using gradle

// Define a variable to store the path to your favicon image
def faviconPath = 'resources/favicon.ico'

// Configure the Javadoc task
javadoc {
    // Include the favicon in the Javadoc output
    options {
        // Add the following line to include the favicon
        headContent = "<link rel='icon' type='image/x-icon' href='$faviconPath'/>"
    }
}

for the title, current gradle properties file already have an option for it only set to the version, it should be "Skript" + version

@MihirKohli
Copy link
Contributor

MihirKohli commented Sep 19, 2023

javadoc {
	source = sourceSets.main.allJava
	classpath = configurations.compileClasspath
	options.encoding = 'UTF-8'
	// currently our javadoc has a lot of errors, so we need to suppress the linter
	options.addStringOption('Xdoclint:none', '-quiet')
}

task releaseJavadoc(type: Javadoc) {
	title = project.name + ' ' + project.property('version')
	source = sourceSets.main.allJava
	classpath = configurations.compileClasspath
	options.encoding = 'UTF-8'
	// currently our javadoc has a lot of errors, so we need to suppress the linter
	options.addStringOption('Xdoclint:none', '-quiet')
}

i have tried various ways still favicon doesn't show up on viewing html
Thank you if you can help me?

@AyhamAl-Ali
Copy link
Member Author

javadoc {
	source = sourceSets.main.allJava
	classpath = configurations.compileClasspath
	options.encoding = 'UTF-8'
	// currently our javadoc has a lot of errors, so we need to suppress the linter
	options.addStringOption('Xdoclint:none', '-quiet')
}

task releaseJavadoc(type: Javadoc) {
	title = project.name + ' ' + project.property('version')
	source = sourceSets.main.allJava
	classpath = configurations.compileClasspath
	options.encoding = 'UTF-8'
	// currently our javadoc has a lot of errors, so we need to suppress the linter
	options.addStringOption('Xdoclint:none', '-quiet')
}

i have tried various ways still favicon doesn't show up on viewing html Thank you if you can help me?

Sounds like you will need more help with that which contradicts the idea behind PRs. I would suggest you create a PR for the titles with the correct way (you sent above) and leave the favicon for others or maybe we will push the changes on your PR

@AyhamAl-Ali AyhamAl-Ali added the PR available Issues which have a yet-to-be merged PR resolving it label Sep 19, 2023
@MihirKohli
Copy link
Contributor

#6045

@AyhamAl-Ali AyhamAl-Ali changed the title 馃挕 Correct Javadocs name, title and favicon 馃挕 Correct Javadocs name, title Sep 21, 2023
@AyhamAl-Ali AyhamAl-Ali added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. documentation Related to Skript's official documentation. enhancement Feature request, an issue about something that could be improved, or a PR improving something. good first issue An issue that would be good for a first-time contributor to make a PR for
Projects
None yet
Development

No branches or pull requests

4 participants