-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: LSP Support #6447
Comments
LSP? Liskov Substitutability Principle? |
LSP Is |
Sure, though I doubt it will be much of a priority. Feel free to make a PR if you're interested in it! |
It is, cause how are people going to use your language when there is no support in their editors? They have to see your documentation to find out the issue. |
I'm not saying it's not valuable, it's just that none of the team members have expressed much interest in similar topics in the past. In addition, the documentation is pretty comprehensive, so there's no urgent gap to fill there, either. |
But if I was you using your language you assume you want intellisence for your language right. But oh that right it's not implemented because you need to implement an LSP server. And so you don't know and you need a browser to look at your documentation. So what do you do then? That why it's really useful in instances where you don't want to have a look at the documentation and you know the code but you forgot the last things about it. It makes your language much easier to master Not Harder. |
To be quite honest you letting hundreds even thousands of people down with no LSP support or intellisence built in. So my take is if there's no intellisence why make a language? |
So yeah I will say good luck at getting VSCode Support ore any Editor Support built in Without LSP Support, Because they all use LSP. |
Because Skript is still intimately tied with Bukkit APIs, a language server would need to either spin up a Bukkit server or work independently of the Skript plugin, neither of which is particularly appealing as a solution. A Bukkit server is clumsy, and projects for parsing independent of a server like skript-parser are a monumental task to make, suffer from feature parity issues, and generally don't seem to receive much interest from developers. Honestly, Skript is a very simple language, and things like auto-completions can, in limited capacity, already be provided by extensions. The effort required to make a language server seems to outweigh the benefit. Skript is an open source project, you're more than welcome to start development work on a language server if you'd like :) |
Don't take things personally mate. This is an open source project that aims to help many users from very different roles to achieve their needs using simple English-like programming. It's meant to be simple using plain English sentences, so LSP wasn't a big concern and still isn't that much especially since none of the team have expressed their will to implement such thing, that doesn't mean we are not interested in adding that. We as a team who are working on this project in our free time as much as we can can't always implement all users wishes. We have skript-grammar project which adds syntax highlighting on different editors like VSCode, Atom, and ST3 and still WIP. If you have the capability to contribute and add LSP to the project feel free to. |
True but evern starting skript-grammar did you evern thought of building a lsp which does all that for plus intellisence in the future? |
But if your language is here to stay it should have the support for it but only when they get the extension or when you deside to fully add it to deafult langs to any editor because it can be handy becacuse it will help you in the proccess of adding it in the future. |
Skript has been around for 13 years. Skript is run by a team of volunteers. If you want LSP, you can either make it yourself or wait until more important and worthwhile tasks are done. You're one of the very very very few to have ever asked for this. |
Because of the nature of Skript as a language it would be almost impossible to create a useful LSP. Fortunately, smart editors like Atom (and probably Microsoft's VS Code) can already provide some semblance of smart autocompletion using the grammar packages that are already available by referencing the code in your script file. Aside from the error parsing (which you can use your own server for, or one of the online parsing tools) there's nothing you don't already have. |
True but there is no offical support for any intellisence or anything for .sk files under skriptlang or anything and so your are using third parties to download an extension potentially eaither stealing your data/installing malware or actually has the support for it. |
As everybody else has said already, if you want this then you're free to produce it yourself, but it's not something that we are able to (or see the need to) dedicate our time and effort to currently. |
This should have been implemented when I get the time I will implement it. |
I have created a fork here but when i get the time I will develop it. |
Suggestion
To add support for LSP for script languages for editors. This will have the ability to tell you hey there is an error in the Skript code before in Realtime not in runtime. Not only that have intellisense for different editors and ide.
Why?
This will be really good for VsCode, IntelliJ and others to add support for the language.
Other
No response
Agreement
The text was updated successfully, but these errors were encountered: