Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializer for WorldGuard regions not found #9

Closed
TPGamesNL opened this issue Jul 24, 2020 · 9 comments
Closed

Serializer for WorldGuard regions not found #9

TPGamesNL opened this issue Jul 24, 2020 · 9 comments
Labels
bug Something isn't working completed For issues like feature requests that have been completed.

Comments

@TPGamesNL
Copy link
Member

Description

WorldGuardRegions can't be serialized even though it should be able to (WorldGuardHook.WorldGuardRegion extends Region which extends YggdrasilExtendedSerializable). It looks like Yggdrasil#getSerializer(Class) returns null.

Steps to Reproduce

Use

on region enter:
	set {region} to event-region

and enter a region.

Expected Behavior

No error and the variable is saved normally

Errors / Screenshots

https://pastebin.com/YRPWv6wj

Server Information

  • Server version/platform: 1.15.2 (paper-379)
  • Skript version: 2.5-alpha6(rev1)

Additional Context

SkriptLang/Skript#3185 could be related / have the same underlying issue

@ShaneBeee
Copy link

I believe this issue was related the SkriptLang/Skript#3185
Can you please retest and let me know what happens.
Hopefully by resolving that underlying issue it will resolve this one as well.

@TPGamesNL
Copy link
Member Author

Issue is still present in 2.5-beta1. About SkriptLang/Skript#3185, which commit fixed it? I can only find the commit that disabled the feature that caused the issue (SkriptLang/Skript@50ae1d5#diff-fa072974f44e81d7b12a1332af9f1f95), not the one that fixed it

@ShaneBeee
Copy link

Yeah nothing actually "fixed" that issue, we just disabled the stuff that caused that issue.

Im not able to replicate the issue. Are you by any chance running FAWE's WorldGuard?

@TPGamesNL
Copy link
Member Author

I'm running paper 385 (1.15.2), worldedit 7.1.0, worldguard 7.0.3, Skript 2.5-beta1

@ShaneBeee
Copy link

Ok I CAN replicate this issue.

@Wafffidooe
Copy link

Isn't the "waiting for reply" label supposed to be removed? :)

@TheLimeGlass TheLimeGlass transferred this issue from SkriptLang/Skript May 6, 2023
@APickledWalrus
Copy link
Member

Not sure if this issue will occur with this addon - will need to verify

@APickledWalrus APickledWalrus added the investigating For issues that are still being investigated label May 6, 2023
@Fusezion
Copy link

Fusezion commented May 6, 2023

I remember in the past with skript using on region enter "blah": after reloading editing the region it no longer was accessable unless we reloaded the skript again, unsure if this is fully related to it but sounds similar to me

@APickledWalrus
Copy link
Member

This issue appears to be resolved. I was able to set a variable to region, restart the server, and use the variable as expected.

@APickledWalrus APickledWalrus added completed For issues like feature requests that have been completed. and removed investigating For issues that are still being investigated labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed For issues like feature requests that have been completed.
Projects
None yet
Development

No branches or pull requests

5 participants