Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the bullet chat be added? #47

Open
NeKoOuO opened this issue May 18, 2024 · 13 comments
Open

Can the bullet chat be added? #47

NeKoOuO opened this issue May 18, 2024 · 13 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@NeKoOuO
Copy link
Contributor

NeKoOuO commented May 18, 2024

現階段的感覺已經非常完善了,下載觀看一條龍,要是能有彈幕功能那追番體驗會上一層樓,想建議加入彈彈的彈幕源,使用弹弹play开放平台 加上 Bangumi Api 來實現彈幕功能,像是KNKPAnime的彈幕功能就做的挺好的和官方的DanDanPlayForAndroid,下面有幾個是其他項目使用的類似案例

https://github.com/open-ani/ani
https://github.com/Predidit/Kazumi
https://github.com/Predidit/oneAnime

想問問您的意見和想法

@SkyD666
Copy link
Owner

SkyD666 commented May 18, 2024

弹幕的话可以考虑,但bangumi api可能不会加入,因为会增加app依赖某个特定平台的程度,而我希望能够尽量提高app通用性

@SkyD666
Copy link
Owner

SkyD666 commented May 19, 2024

你知道目前还在维护的开源弹幕库有哪些吗?

@NeKoOuO
Copy link
Contributor Author

NeKoOuO commented May 19, 2024

https://github.com/OpenDanmakuCommunity/awesome-danmaku
這邊感覺可以參考下

@Luffyirl
Copy link

Luffyirl commented May 19, 2024

弹幕的话可以考虑,但bangumi api可能不会加入,因为会增加app依赖某个特定平台的程度,而我希望能够尽量提高app通用性

Wont this make the app dependent on a online service ? Have u really make ur mind adding the feature or is it open to debate for implementation? .

I'm really opposed to the suggestion. The app is so close to complete I'd rather want improvement in other parts instead of a service linked to it .

Being able to run without any dependencies is waht makes anivu great and thats why i love ♥️ it .

And barrage file import is gud .

@NeKoOuO
Copy link
Contributor Author

NeKoOuO commented May 19, 2024

@Luffyirl This feature is essentially switchable and should not have dependency issues. It's more like an extension; even if it's absent or not working, it won't cause any problems.

@SkyD666
Copy link
Owner

SkyD666 commented May 19, 2024

I think there should be more isolation and abstraction between external services and app

@SkyD666 SkyD666 added enhancement New feature or request help wanted Extra attention is needed labels May 19, 2024
@Ripl0gic
Copy link

Ripl0gic commented May 19, 2024

@Luffyirl This feature is essentially switchable and should not have dependency issues. It's more like an extension; even if it's absent or not working, it won't cause any problems.

Will it be online tho ? Coz having a online service linked isn't what most people prefer when they torrent. If i can grab the XML or JSON file from Niconico/Acfun/Bilibili and import it to the app then it'd better.

@Ripl0gic
Copy link

Probably some kind of extension based system for importing the files would be much better.

I remember someone mentioning torrentio search Engine ( which is also a very great and organised Library for searching through media torrents) in teligram. But aain thats a online service which makes the app dependent on that.

But if its like a extension module then only people who want to use the extension can use download it .

I don't remember the app name correctly but there is a great app which has extension based system for watching content. That can be taken as inspiration.

@Luffyirl
Copy link

Probably some kind of extension based system for importing the files would be much better.

I remember someone mentioning torrentio search Engine ( which is also a very great and organised Library for searching through media torrents) in teligram. But aain thats a online service which makes the app dependent on that.

But if its like a extension module then only people who want to use the extension can use download it .

I don't remember the app name correctly but there is a great app which has extension based system for watching content. That can be taken as inspiration.

Yep this would also improve the isolation between the app and external services . Also if someone wants to make their own extension they won't have to interact with the main app code to understand it , they can just take inspiration for the example extension module and how it sends info to the app.

@Bubblekey
Copy link

Bubblekey commented May 19, 2024

I don't remember the app name correctly but there is a great app which has extension based system for watching content. That can be taken as inspiration.

U probably mean Aniyomi (better for kuukiyomi) or tachiyomi/mihon

Another advantage is if u add extension service then if some content provider claims a dmca lawsuit then it would only apply to the extension repo and not the main app so u can just take down that extension or move the repo . So no reputational harm for main app repository.

All the apps mention has been greatly successful in what they do .

@NeKoOuO
Copy link
Contributor Author

NeKoOuO commented May 20, 2024

But I think simple bullet chat service should not have any infringement issues, right?

@NeKoOuO NeKoOuO changed the title 能否增加彈幕功能 Can the bullet screen function be added? May 20, 2024
@NeKoOuO NeKoOuO changed the title Can the bullet screen function be added? Can the bullet chat be added? May 20, 2024
@NeKoOuO
Copy link
Contributor Author

NeKoOuO commented May 20, 2024

@Luffyirl This feature is essentially switchable and should not have dependency issues. It's more like an extension; even if it's absent or not working, it won't cause any problems.

Will it be online tho ? Coz having a online service linked isn't what most people prefer when they torrent. If i can grab the XML or JSON file from Niconico/Acfun/Bilibili and import it to the app then it'd better.

@SkyD666 @Ripl0gic
I think an interesting point mentioned is importing through downloading XML files, and now the official Android version also uses a similar function, so I think we can follow the official practice

@Bubblekey
Copy link

But I think simple bullet chat service should not have any infringement issues, right?

Yeh this is like subtitle file right ? It won't have any problems I think.

@SkyD666 SkyD666 pinned this issue Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants