Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bars Features #564

Open
1 of 4 tasks
x-yingcan-x opened this issue Feb 21, 2024 · 9 comments
Open
1 of 4 tasks

Bars Features #564

x-yingcan-x opened this issue Feb 21, 2024 · 9 comments
Labels
new feature This issue or PR is a new feature

Comments

@x-yingcan-x
Copy link

x-yingcan-x commented Feb 21, 2024

Features

  • Use 9-slice, seperate, (grayscale) textures
  • Display overflow amount on mana bar
  • Health including absorption
  • EHP calculation
  • Mana/HP cost preview
  • Ultimate Ability CD in dungeon

Customization

  • able to change bars/numbers color
  • toggle display icons or not
  • able to change bar/number position
  • able to move numbers/bars/icons

Screenshots

strange bar texture
bars

@x-yingcan-x x-yingcan-x added the bug Something isn't working label Feb 21, 2024
@alexytomi
Copy link

I also found this when I was making a texture for the bars. It seems to just repeat the texture to fill in the missing gaps that having a longer bar causes because the actual texture is sized for the default settings

I assumed it was intended but maybe not

maybe have seperate textures for all bar lengths?

@Julienraptor01
Copy link
Contributor

i believe we should just use some 9-slice texture for the bars as it would allow it to work with any size
i have looked into it at some point, but i have a lot of IRL stuff
the fancy bars are mostly untouched since 2 years (except for simply making it work on new versions) and we should probably do a big refactor of that code and clean it up

@x-yingcan-x
Copy link
Author

x-yingcan-x commented Feb 21, 2024

i may change this issue to Feature request,
3-slice / seperate texture for all lengths / auto generate based on a grayscale for correct bar texture

and correct health (not include shield now) + soulflow amount on bar
2024-02-21_21 43 52

@Julienraptor01
Copy link
Contributor

i may change this issue to Feature request, 3-slice / seperate texture for all lengths / auto generate based on a grayscale for correct bar texture

and correct health (not include shield now) + soulflow amount on bar 2024-02-21_21 43 52

overflow mana is supposed to show on bar, but not soulflow

also minecraft does now support 9-slice textures which would make it easy
generate from a grayscale and color it could also be done
true health is not a thing we can easily do as it require to do calculcations

||also wth is your FPS, you're spoofing it right ?||

@x-yingcan-x
Copy link
Author

yeah, I mixed overflow and soulflow
I know 9-slice, but it doesnt suit to bar, generate from grayscale may better
true health is just above my head, the problem is how we get it

btw, do you want moar fps?

@Julienraptor01
Copy link
Contributor

Julienraptor01 commented Feb 21, 2024

yeah, I mixed overflow and soulflow I know 9-slice, but it doesnt suit to bar, generate from grayscale may better true health is just above my head, the problem is how we get it

btw, do you want moar fps?

9-slice does suit to bar as it would allow to basically make the bar have any shape + we can do 9-slice and have it recolored via shader in the same time

yeah for dungeons we could find a way pull the true health and remove the real health and defense bar

but that need a refactor of the bar code anyway

||also i knew it :)||

@AzureAaron
Copy link
Collaborator

Similar to #108

@x-yingcan-x x-yingcan-x changed the title Strange bar texture Bars Features Feb 22, 2024
@x-yingcan-x
Copy link
Author

pls remove bug label and give a feature label
also, I have no idea abt where should we put EHP (maybe a standalone thing, instead of replacing health and def bar)

@AzureAaron AzureAaron added new feature This issue or PR is a new feature and removed bug Something isn't working labels Feb 22, 2024
@AzureAaron
Copy link
Collaborator

pls remove bug label and give a feature label also, I have no idea abt where should we put EHP (maybe a standalone thing, instead of replacing health and def bar)

Done. Also EHP kind of exists indirectly as the defence bar represents the % damage reduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

No branches or pull requests

4 participants