Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest topic names in revup amend #12

Closed
jerry-skydio opened this issue Aug 18, 2022 · 3 comments
Closed

Suggest topic names in revup amend #12

jerry-skydio opened this issue Aug 18, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Issues that might be a good fit for first time contributors

Comments

@jerry-skydio
Copy link
Collaborator

Users might like to know their previous topics so that they can either make a commit in the same topic, or make a commit relative to a topic. Similarly we can suggest previous commonly used reviewers and labels.

This information can be populated in the # commented out block when editing the commit message

Also add "revup commit" that is essentially the same as "revup amend --insert" and will bring these features to new commits as well.

@jerry-skydio jerry-skydio added the enhancement New feature or request label Aug 18, 2022
@jerry-skydio jerry-skydio added the good first issue Issues that might be a good fit for first time contributors label Sep 13, 2022
@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Sep 20, 2022

thanks for taking this on

some other suggestions for follow-up changes:

--same-topic flag, when used automatically appends a "Topic:" line with the same topic as the most recent commit
--relative-topic flag that's similar, but appends an empty "Topic:" and a "Relative:" with the previous topic
--new-topic flag appends only an empty "Topic:"

these flags could also add "Reviewers:", "Assignees:", "Labels:" lines

--same-topic doesn't need to add anything since those lines would have been set in a previous commit
--relative-topic matches reviewers, assignees, labels, of the relative topic if they were set
--new-topic appends empty reviewers, assignees, labels. maybe start out commented out?

@malcolm-leclair-skydio
Copy link
Contributor

I'd also love to replicate functionality like git commit -m "Commit Msg" so you can make a quick revup commit without opening an editor like revup commit -m "Quick commit message" -t "topic_name" -r "jerry-skydio"

@jerry-skydio
Copy link
Collaborator Author

further enhancements tracked in #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Issues that might be a good fit for first time contributors
Projects
None yet
Development

No branches or pull requests

2 participants