Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] showRateDialog on iOS, parameters not taken into account #61

Closed
fvisticot opened this issue Jul 22, 2020 · 7 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@fvisticot
Copy link

Describe the bug
If I use showRateDialog on iOS and try to fill parameters like title, message, listener
It seems those parameters are not taken into account. By example listener is not fired

To Reproduce
Steps to reproduce the behavior:

  1. Start the RateDialog using the RateMyAppBuilder widget

Expected behavior
listener are fired to manage RateMyAppDialogButton.rate / RateMyAppDialogButton.later

@fvisticot fvisticot added the bug Something isn't working label Jul 22, 2020
@Skyost
Copy link
Owner

Skyost commented Jul 22, 2020

Just pass ignoreIOS to true or see #1.

@fvisticot
Copy link
Author

fvisticot commented Jul 22, 2020

Does not work even with ignoreIOS set to false.
I have also tested your sample code on the iOS. using both builder and RateMyApp Widget.
In any case on iOS the title, message and other parameters are taken into account.
Only the default ioS Rating dialog is displayed with default title / buttons.

@Skyost
Copy link
Owner

Skyost commented Jul 22, 2020

What are you calling "default ioS Rating dialog" ? Do you mean the native iOS rating dialog ?

@fvisticot
Copy link
Author

yes

@Skyost
Copy link
Owner

Skyost commented Jul 22, 2020

Oh sorry, I meant ignoreIOS set to true (edited my previous comment). Be warned tho, this is not recommended by Apple.

@fvisticot
Copy link
Author

tx for the support.
I think documentation should be updated to clearly explain what is possible for iOS and Android.
To be clear, i think iOS is more restrictive and allows only "standart review Dialog" and thats all.

In case of iOS (ignoreIOS set to FALSE) do you think we can retrieve the userRating with a listener ?
If i want to redirect with a review page if rating is greater than 4 how to do that ?

@Skyost
Copy link
Owner

Skyost commented Jul 22, 2020

I think documentation should be updated to clearly explain what is possible for iOS and Android.

Yeah, I may need to clarify some points.

In case of iOS (ignoreIOS set to FALSE) do you think we can retrieve the userRating with a listener ?

Sadly, it's not possible as Apple is not providing any callback on their dialog.

@Skyost Skyost closed this as completed Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants