Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorings/improvements for requests #4

Merged
merged 3 commits into from Jun 30, 2015

Conversation

ddudnik
Copy link
Contributor

@ddudnik ddudnik commented Jun 29, 2015

Hi,

Digging my way through the code, here are some changes/refactorings which I suggest:

  • more generic 'make_request' method. Nicely isolates 'requests' lib (it's used only there now). All other methods use it to talk to API.
  • generic 'get_results' and 'create_session' methods, so the overall API of all classes becoming more in sync
  • improvement for handling errors in response

Cheers,
Denis

@ardydedase
Copy link
Contributor

Thanks @ddudnik, the classes look much better than before.

Cheers,
Ardy

ardydedase added a commit that referenced this pull request Jun 30, 2015
Refactorings/improvements for requests
@ardydedase ardydedase merged commit 961ca16 into Skyscanner:master Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants