Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media3 integration, handle audio focus gain/lost #18

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Jan 20, 2022

Media3 pros:

  • same player interface, which ease switching from playing in activity to playing in service
  • out of the box integration with wear watches, google assistant, bluetooth headset etc. (by implementing mediasessionservice)
  • exoplayer as core, so switching from exoplayer is straightforward

Cons:

  • Need to refactor
  • New bugs, such as crashing when playing in mediasessionservice. (which forces to use media metadata+medialibraryservice+mediaitemfiller).

@ghost ghost requested a review from Skyyo January 20, 2022 15:00
@Skyyo
Copy link
Owner

Skyyo commented Jan 29, 2022

all is clear, thanks for the research @ahamula . Seems media3 really doesn't provide anything of use now. Maybe we'll go for it when we need something with wear os, but even then we'll need to compare it with alternatives. Possibly they will force this upon us and deprecate the ExoPlayer.

@Skyyo Skyyo closed this Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant