New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android13 changes #38
Conversation
ghost
commented
Jun 15, 2022
- new google API to handle in-app language changes
- simple backup configuration
- new savedstatehandle to get/set StateFlow's from it
- ability to test changes with fragments
- ability to pick 1/multiple images from gallery
- 2 helper methods to observe changes, made by other fragments, and to get savedhandle to make this changes
- use hiltViewModel() method instead of "by viewModels" helper method in compose fragment
…3_changes # Conflicts: # app/build.gradle
…introduce few helper "observe" methods, use new savedstatehandle apis, improve fragments to get rid of "by viewModels" extensions in compose fragments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pushed few changes since
new google API to handle in-app language changes
was misused. Though there is an issue on Android versions lower than Android 13 - activity isn't restarted automatically. Not sure if that's intended, or will be changed when Android 13 is released. If this issue persists - we will need to add a TODO into the readme here and to check on it later - ability to test changes with fragments - can you please elaborate on this one? Didn't understand what to check.
2 helper methods to observe changes, made by other fragments, and to get savedhandle to make this changes
- let's please try to apply them in the package namednavigateWithResult
, if it simplifies things.use hiltViewModel() method instead of "by viewModels" helper method in compose fragment
- can you please remind me if we can drop dependency or is there any noticable benefit of doing so? Seems it makes more sense to use the current approach until we ditchFragments
completely
Good job overall @ahamula !
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 - in case activity restarts, we need to ensure that everything else knows that locale changed. We want every Android version to react immediately, like on the Android 13 atm.
2 - no need or fragments in this project. Didn't delete them yet, since there is still usage of your 2 extensions.
3 - here. These screens showcase passing fields up & down
4 - got it, won't be using it for now.
@Skyyo Fixed navigation in "dog"/"cat" places, fixed layout direction on android 12 |
# Conflicts: # app/build.gradle # app/src/main/AndroidManifest.xml
# Conflicts: # app/build.gradle # app/src/main/java/com/skyyo/samples/application/Destination.kt # app/src/main/java/com/skyyo/samples/application/activity/PopulatedNavHost.kt # app/src/main/java/com/skyyo/samples/features/sampleContainer/SampleContainerScreen.kt # app/src/main/java/com/skyyo/samples/features/sampleContainer/SampleContainerViewModel.kt