fix bounding box function, get rid of extensions, copied from imported libraries #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
As you can see, there are 2 bugs in current getBoundingBoxes implementation:
If you still need this "trim box to width" functionality, than maybe we can mix implementations, but better idea would be to create feature request to TextField composable (more precisely to TextLayoutResult) to return trimmed bounding boxes (for example with next function TextLayoutResult.getPathForRange(start, end, trim: Boolean)