Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FaloopIntegration] Empty message into 'System.ArgumentNullException: Value cannot be null.' #655

Closed
drejjmit opened this issue Apr 24, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@drejjmit
Copy link

drejjmit commented Apr 24, 2024

I noticed a lot of empty announcements. If you look at their Discord, there are no coords until in this case 10 seconds. Could you ignore printing of spawns with no spawn data?

image

10:30:23.578 | DBG | [FaloopIntegration] Event "message" = "[{\"type\":\"mob\",\"subType\":\"report\",\"data\":{\"action\":\"spawn\",\"id\":{\"mobId\":\"gunitt\",\"worldId\":\"omega\"},\"data\":{\"zoneId2\":\"the_tempest\",\"location\":null,\"timestamp\":\"2024-04-24T08:30:23.469Z\",\"window\":1,\"stage\":null}}}]"
10:30:23.578 | DBG | [FaloopIntegration] OnMobReport: unknown zone poi id found: 0

And the second announce 10 seconds later with the actual spawn data got an error so it was never printed in chat:

10:30:33.876 | DBG | [FaloopIntegration] Event "message" = "[{\"type\":\"mob\",\"subType\":\"report\",\"data\":{\"action\":\"spawn_location\",\"id\":{\"mobId\":\"gunitt\",\"worldId\":\"omega\"},\"data\":{\"zonePoiId\":1034}}}]"
10:30:33.877 | ERR | [FaloopIntegration] HandleOnMessage
	System.ArgumentNullException: Value cannot be null. (Parameter 'key')
	   at System.Collections.Generic.Dictionary`2.FindValue(TKey key)
	   at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
	   at Divination.FaloopIntegration.FaloopIntegration.OnMobReport(MobReportData data) in D:\a\Divination\Divination\FaloopIntegration\FaloopIntegration.cs:line 131
	   at Divination.FaloopIntegration.Faloop.FaloopSocketIOClient.HandleOnMessage(SocketIOResponse response) in D:\a\Divination\Divination\FaloopIntegration\Faloop\FaloopSocketIOClient.cs:line 171

I'm on v6.58.9.0

Edit:
Another example

13:17:08.121 | DBG | [FaloopIntegration] Event "message" = "[{\"type\":\"mob\",\"subType\":\"report\",\"data\":{\"action\":\"spawn\",\"id\":{\"mobId\":\"nunyunuwi\",\"worldId\":\"spriggan\"},\"data\":{\"zoneId2\":\"southern_thanalan\",\"location\":null,\"timestamp\":\"2024-04-26T11:17:07.948Z\",\"window\":1,\"stage\":null}}}]"
13:17:08.121 | DBG | [FaloopIntegration] OnMobReport: unknown zone poi id found: 0
13:17:11.879 | DBG | [FaloopIntegration] Ping
13:17:11.879 | DBG | [FaloopIntegration] Pong: 00:00:00.0000256
13:17:13.871 | DBG | [FaloopIntegration] Event "message" = "[{\"type\":\"mob\",\"subType\":\"report\",\"data\":{\"action\":\"spawn_location\",\"id\":{\"mobId\":\"nunyunuwi\",\"worldId\":\"spriggan\"},\"data\":{\"zonePoiId\":283}}}]"
13:17:13.871 | ERR | [FaloopIntegration] HandleOnMessage
	System.ArgumentNullException: Value cannot be null. (Parameter 'key')
	   at System.Collections.Generic.Dictionary`2.FindValue(TKey key)
	   at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
	   at Divination.FaloopIntegration.FaloopIntegration.OnMobReport(MobReportData data) in D:\a\Divination\Divination\FaloopIntegration\FaloopIntegration.cs:line 131
	   at Divination.FaloopIntegration.Faloop.FaloopSocketIOClient.HandleOnMessage(SocketIOResponse response) in D:\a\Divination\Divination\FaloopIntegration\Faloop\FaloopSocketIOClient.cs:line 171

image

@drejjmit drejjmit added the bug Something isn't working label Apr 24, 2024
@SlashNephy SlashNephy self-assigned this Apr 28, 2024
@SlashNephy
Copy link
Owner

Hi!
Sorry for the late response. I just released v6.58.10.
Release 6.58.10 · SlashNephy/Divination

Can you close the Issue once you are sure the issue has been resolved?

@drejjmit
Copy link
Author

I don't see the option in settings, but i'll just set the bool in the json for now

image
image

@SlashNephy
Copy link
Owner

Sorry. I just forgot to add checkbox...
52ac778
Fixed in 6.58.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants