Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slot Access Feature Preview #101

Merged
merged 7 commits into from Jan 30, 2023
Merged

Slot Access Feature Preview #101

merged 7 commits into from Jan 30, 2023

Conversation

agnor99
Copy link
Contributor

@agnor99 agnor99 commented Dec 29, 2022 •
edited

Description

Added Feature to MachineInventoryLayout to reduce the need for magic numbers when getting ItemStacks (the SingleSlotAccess can be expanded to add more methods for interacting with the inventory)

Todo

  • Move all calls on MachineInventory with magic number access to the SlotAccess System

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@Rover656 Rover656 added Area-Backend Backend work not usually visible to players. Type-RFC Request for comments. MC-1.19.2 labels Dec 29, 2022
@mystchonky mystchonky mentioned this pull request Jan 6, 2023
Merged
12 tasks
@mystchonky mystchonky mentioned this pull request Jan 13, 2023
Merged
EpicSquid
EpicSquid approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@EpicSquid EpicSquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thought I had already responded to this but apparently not. Ship it

@agnor99 agnor99 merged commit 0541277 into Team-EnderIO:dev/1.19.x Jan 30, 2023
albinaask pushed a commit to albinaask/EnderIO-Rewrite that referenced this pull request Apr 2, 2023
@agnor99 @albinaask
Slot Access Feature Preview (Team-EnderIO#101)
9b3171d 
* Slot Access Feature Preview

* removed temportary maven for registrate

* Use MultiSlotAccess for Sagmill output

* completed slot accesss

* Menus use SlotAccess, added some validation

* impulse hopper things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpicSquid EpicSquid EpicSquid approved these changes

@Rover656 Rover656 Rover656 approved these changes

Assignees
No one assigned
Labels
Area-Backend Backend work not usually visible to players. MC-1.19.2 Type-RFC Request for comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@agnor99 @EpicSquid @Rover656