Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixed shading and moved endercore to a separate repo. #12

Closed
wants to merge 12 commits into from

Conversation

Rover656
Copy link
Member

Description

Moves endercore out to its own repo, brings it in over maven and takes shadowing out of this project completely, fixing the problem with duplicating registrate code.

Todo

  • Setup the endercore repository
  • Get endercore publishing to maven
  • Setup maven properly in this project
  • Final checks

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@Rover656 Rover656 added Type-Bug There is a problem. 1.18 Status-Blocked Blocked by a specific issue or protocol. labels Dec 30, 2021
@Rover656
Copy link
Member Author

Builds will fail due to unavailability of EnderCore over maven. This'll get fixed once maven publishing is setup on a new repo for EnderCore.

@Rover656
Copy link
Member Author

Massively overcomplex compared to a new solution that should've taken 10 mins

@Rover656 Rover656 closed this Dec 31, 2021
Trytoon pushed a commit to Trytoon/EnderIO-Rewrite that referenced this pull request Mar 25, 2023
* Apply alloy textures by "DTFuel" released under CC0

* License meta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status-Blocked Blocked by a specific issue or protocol. Type-Bug There is a problem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant