Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gradle (maybe for real this time) #13

Merged
merged 7 commits into from Dec 31, 2021
Merged

Fix gradle (maybe for real this time) #13

merged 7 commits into from Dec 31, 2021

Conversation

Rover656
Copy link
Member

@Rover656 Rover656 commented Dec 31, 2021 •
edited

Description

  • Fixes shade duplication by excluding registrate from all the jars except enderio-base.
  • Fixes the gradle weirdness bug that is caused by reobfuscating too early (likely preventing many future bugs).

ToDo

  • Decide whether we squash endercore into enderio-base. If so, dewit

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@Rover656 Rover656 added Type-Bug There is a problem. 1.18 labels Dec 31, 2021
@Rover656 Rover656 marked this pull request as ready for review December 31, 2021 16:59
@Rover656
Copy link
Member Author

We're ready for a review, we squashed core into base now

Rover656
Rover656 commented Dec 31, 2021
View reviewed changes
enderio-base/src/main/java/com/enderio/base/EnderIO.java

@Mod(EnderIO.MODID)
public class EnderIO {
public static final @Nonnull String MODID = "enderio";

private static final Lazy<Registrate> REGISTRATE = Lazy.of(() -> Registrate.create(MODID));

public static final Logger LOGGER = LogManager.getLogManager().getLogger(MODID);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note for future - might be worth utilising logging more now that I think about it.

@Rover656
Copy link
Member Author

Merging, actions are working fine and it all works fine locally.

@Rover656 Rover656 merged commit a878b73 into Team-EnderIO:dev/1.18.x Dec 31, 2021
@Rover656 Rover656 mentioned this pull request May 30, 2022
Merged
7 tasks
Trytoon pushed a commit to Trytoon/EnderIO-Rewrite that referenced this pull request Mar 25, 2023
@agnor99
added permissions for the usage of CastCrafter/travel_anchors (Team-E…
c493064 
…nderIO#13)

* added permissions for the usage of CastCrafter/travel_anchors

* fixed last preview image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type-Bug There is a problem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Rover656